Fix for SpartanJ/ecode#371.

Slightly increase brighness in inactive tab text color.
SpartanJ · Dec 19, 2024 · 98c387f · 98c387f
1 parent 90ef341
commit 98c387f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/bin/assets/ui/breeze.css b/bin/assets/ui/breeze.css
@@ -27,7 +27,7 @@
 	--tab-hover: #334e5e;
 	--tab-close: #909396;
 	--tab-close-hover: #863d47;
-	--tab-font-inactive: #b6bbc2;
+	--tab-font-inactive: #c0c5cc;
 	--icon: #b6bbc2;
 	--icon-active: white;
 	--icon-back-hover: #eff0f1;

diff --git a/src/tools/ecode/settingsmenu.cpp b/src/tools/ecode/settingsmenu.cpp
@@ -1053,14 +1053,17 @@ UIMenu* SettingsMenu::createEditMenu() {
 
 UIMenu* SettingsMenu::createWindowMenu() {
 	mWindowMenu = UIPopUpMenu::New();
+	auto shouldCloseCb = []( UIMenuItem* ) -> bool { return false; };
 	UIPopUpMenu* colorsMenu = UIPopUpMenu::New();
 	colorsMenu
 		->addRadioButton( i18n( "light", "Light" ),
 						  mApp->getUIColorScheme() == ColorSchemePreference::Light )
+  	  ->setOnShouldCloseCb( shouldCloseCb )
 		->setId( "light" );
 	colorsMenu
 		->addRadioButton( i18n( "dark", "Dark" ),
 						  mApp->getUIColorScheme() == ColorSchemePreference::Dark )
+		->setOnShouldCloseCb( shouldCloseCb )
 		->setId( "dark" );
 	colorsMenu->on( Event::OnItemClicked, [this]( const Event* event ) {
 		if ( !event->getNode()->isType( UI_TYPE_MENUITEM ) )