-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collision fixing #44
Collision fixing #44
Conversation
for merge, keep all constants from main |
Also, Alexis, if you're reading this I just realized that the home command sometimes almost swings the elbow around 360 degrees instead of directly going back, i.e. if the target angle is 0 and the robot is at 330 degrees, it'll spin 330 degrees instead of 30. |
You need to do this on your branch when you merge main into your branch before doing the PR. Don't make PRs that can't be just directly merged to the best of your ability. |
…ing" This reverts commit bcbd939.
Fixed 👍 |
@cycIes elbow collision added/fixed |
() -> | ||
(ElevatorStates.getPosition().getAsDouble() > 1.0) | ||
|| ElbowStates.getPosition().getAsDouble() | ||
< percent.getAsDouble()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this part, I'm assuming you're saying the elbow can move if it's just trying to go higher? Would you have to account for negative angles as well? (the 0 for the elbow is pointing up)
edited: oops i meant for this to be a simple comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I realize now that checking elbow against elevator position is tricky because depending on where the shoulder is, the elbow vertical displacement is different
I gave weights to elbows and shoulders based on real length to get a percent of total height, then using that to check for elevator. |
Collision detection added, ready for merge