This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Refactor spinwave.m to be more object oriented
#4
Assignees
Comments
krishnakumarg1984
added a commit
that referenced
this issue
Mar 4, 2021
# This is the 1st commit message: updates the descriptive comments for the biquadratic hamiltonia constructor to be consistent with updated argument names # This is the commit message #2: Update swfiles/+sw_classes/biquadratic_hamiltonian.m Use more descriptive names for the biquadratic hamiltonian constructor Co-authored-by: Anders Markvardsen <[email protected]> # This is the commit message #3: Renames the arguments of the hamiltonian class constructor to better reflect its meaning # This is the commit message #4: Wrote a brief description of the variable 'nChunks' # This is the commit message #5: adds a description of nHkl as a comment # This is the commit message #6: Update swfiles/+sw_classes/magnetic_structure.m Provides a brief comment on the 'magnetic_structure' class Co-authored-by: Duc Le <[email protected]>
mducle
added a commit
that referenced
this issue
Apr 1, 2021
# This is the 1st commit message: updates the descriptive comments for the biquadratic hamiltonia constructor to be consistent with updated argument names # This is the commit message #2: Update swfiles/+sw_classes/biquadratic_hamiltonian.m Use more descriptive names for the biquadratic hamiltonian constructor Co-authored-by: Anders Markvardsen <[email protected]> # This is the commit message #3: Renames the arguments of the hamiltonian class constructor to better reflect its meaning # This is the commit message #4: Wrote a brief description of the variable 'nChunks' # This is the commit message #5: adds a description of nHkl as a comment # This is the commit message #6: Update swfiles/+sw_classes/magnetic_structure.m Provides a brief comment on the 'magnetic_structure' class Co-authored-by: Duc Le <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, there is a single large class
spinwwith several large methods / functions - especiallyspinwave.m.To make it easier to port to C++ and also to write unit tests for (system tests already exist), this code should be refactored to be more object oriented, and the code split into more modular blocks / methods.
The text was updated successfully, but these errors were encountered: