Better versions #21
Merged
Better versions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # buildSrc/src/main/kotlin/io/spine/internal/dependency/Jackson.kt # buildSrc/src/main/kotlin/io/spine/internal/gradle/publish/Artifacts.kt # buildSrc/src/main/kotlin/io/spine/internal/gradle/publish/PublishingConfig.kt # buildSrc/src/main/kotlin/io/spine/internal/gradle/publish/SpinePublishing.kt # buildSrc/src/main/kotlin/io/spine/internal/gradle/publish/Tasks.kt # license-report.md # version.gradle.kts
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
============================================
+ Coverage 55.45% 56.42% +0.97%
- Complexity 449 468 +19
============================================
Files 132 137 +5
Lines 2382 2504 +122
Branches 145 158 +13
============================================
+ Hits 1321 1413 +92
- Misses 1015 1037 +22
- Partials 46 54 +8 |
... for failure on manifest loading Also: * Remove redundant test.
Also: * Test string form.
armiol
approved these changes
May 7, 2022
This was referenced May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements storing a version of a software component in JAR manifest files. This mechanism is going to replace the one used in ProtoData . We need to replace the currently used approach (which uses
version.txtresource files) because it would break when we have more than one artifact with such a resource.The loading is done by the
KManifestclass which wraps around standard JavaManifestand itsAttributes.Storing of necessary attributes is done by the script plugin
write-manifest.gradle.ktswhich should be applied to each subproject which needs version information. This script plugin will be added toconfigafter latest version oftool-baseand the script plugin are applied to ProtoData.This PR also partially addresses the issue #19, implementing the loading of dependency information from a custom
Depends-Onattribute. The storing (presumably done by another script plugin) would be implemented in a scope of another PR.