Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13.1 to crossScalaVersions and update the dependencies #7

Closed
wants to merge 4 commits into from

Conversation

azolotko
Copy link

No description provided.

@azolotko azolotko force-pushed the scala-version-update branch 8 times, most recently from c5d3177 to 004f85c Compare September 23, 2019 12:59
@azolotko
Copy link
Author

Tests are failing randomly on Travis CI. I couldn't reproduce it locally, will take a look later.

@azolotko azolotko force-pushed the scala-version-update branch from 004f85c to b70db9e Compare September 23, 2019 14:42
@azolotko azolotko force-pushed the scala-version-update branch 2 times, most recently from 27ecd21 to 825e0f5 Compare October 4, 2019 11:04
@azolotko azolotko force-pushed the scala-version-update branch from 825e0f5 to 21566b1 Compare October 21, 2019 13:42
@felixbr
Copy link

felixbr commented Dec 15, 2019

Hey 🙂

I'm interested in using this with 2.13.1, so I looked at the failing runs on Travis and it seems that the .unsafeRunTimed(10.seconds) in the tests is a little too short. Locally I could reproduce the same errors by reducing it to 8.seconds.

Maybe we can just increase the timeout to 15.seconds and get this up and running?

@azolotko
Copy link
Author

@felixbr the last attempt was .unsafeRunTimed(30.seconds), but it still fails randomly. I suspect the problem is bigger than just the properly set timeout.

@felixbr
Copy link

felixbr commented Dec 18, 2019

It seems like I fixed the issue over at #8 🎉

Feel free to cherry-pick my commit onto your PR, as you've done the bulk of the work 🙂

@felixbr felixbr mentioned this pull request Dec 18, 2019
@felixbr
Copy link

felixbr commented Dec 19, 2019

I think you shouldn't update sbt in this PR. If you insist to update sbt, I recommend to use 1.3.4 instead of 1.3.5, as the latter has class loading issues.

@azolotko
Copy link
Author

@felixbr Thanks Felix. I've also figured this out. The hard way :)

@azolotko
Copy link
Author

azolotko commented Dec 19, 2019

@felixbr The TravisCI build is still failing...

@felixbr
Copy link

felixbr commented Dec 19, 2019

Hm strange, my debug PR (#8) worked on the first try 🤔

@azolotko
Copy link
Author

@felixbr Great. I'll then just close mine and you can remove [WIP | Travis-Debug] from yours and let's hope it'll get merged soon.

@azolotko azolotko closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants