Update instructions for 9.0 upgrade #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small typo ("SpiriitLexik" instead of just "Lexik") in the upgrade readme. I took the opportunity to also add the additional changes that have to be made in
bundles.phpand the bundle configuration file to complete the switch fromlexik/form-filter-bundletospiriitlabs/form-filter-bundle. The bundle registration is covered by the recipe but I figured it couldn't hurt to include it too.I would suggest to move the information about the namespace change from the issue directly to the top of the readme of the original repo, so its more visible.
The new
SpiriitLabs/form-filter-bundlerepo also currently has issues disabled... unless thats intentional.. ;)