Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of the deprecated base extension from HttpKernel #38

Merged

Conversation

SebLevDev
Copy link
Contributor

The base extension available in HttpKernel only adds support for registering some classes to be added in the cache warmer of the doctrine/annotations parser, compared to the base class of the DI component. As annotations are not supported anymore in Symfony 7, this base class has been deprecated in Symfony 7.1. As this bundle does not rely on the extra feature, it can use the base class from DI directly.

The base extension available in HttpKernel only adds support for registering some classes to be added in the cache warmer of the doctrine/annotations parser, compared to the base class of the DI component. As annotations are not supported anymore in Symfony 7, this base class has been deprecated in Symfony 7.1. As this bundle does not rely on the extra feature, it can use the base class from DI directly.
@gilles-g
Copy link
Contributor

Hi @SebLevDev

Good catch! Thx

@gilles-g gilles-g merged commit 34d2a67 into SpiriitLabs:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants