Nopol actor #10
Merged
Nopol actor #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danglotb
force-pushed
the
nopol-actor
branch
from
22ee7e5 to
5a1b201
Compare
danglotb
force-pushed
the
nopol-actor
branch
from
5a1b201 to
083c7a0
Compare
|
add a test |
danglotb
commented
Sep 20, 2016
| try { | ||
| Main.initJSAP(); | ||
| } catch (JSAPException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
remove + throws Exception in method
| System.out.println(Arrays.toString(args)); | ||
| List<Patch> patches = Collections.EMPTY_LIST; | ||
| if (Main.parseArguments(args)) { | ||
| File[] sourceFiles = new File[Config.INSTANCE.getProjectSourcePath().length]; |
There was a problem hiding this comment.
singleton incompatible with multiple Nopol. first refactor Config.
|
|
||
| @Override | ||
| public void onReceive(Object message) throws Exception { | ||
| if (message instanceof String) { |
There was a problem hiding this comment.
use config object instead of String
tdurieux
approved these changes
Sep 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NopolActor is responsible to run Nopol remotely for the ui-intellij.