Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for stats-output-file in maven-plugin #908

Merged
merged 5 commits into from
Oct 17, 2022
Merged

feat: add support for stats-output-file in maven-plugin #908

merged 5 commits into from
Oct 17, 2022

Conversation

algomaster99
Copy link
Member

Continuation of #907

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 17, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

@algomaster99
Copy link
Member Author

Unfortunately, we will lose coverage because subprocess instrumentation is a different task on its own. See ASSERT-KTH/collector-sahab#63. I reverted the change there because of flaky behaviour.

@algomaster99
Copy link
Member Author

Sonatype also complains, but I do not see them as a threat. I will cater to them if I am convinced otherwise.

@algomaster99 algomaster99 merged commit 8076dc4 into master Oct 17, 2022
@algomaster99 algomaster99 deleted the add-stats-output-file branch October 17, 2022 17:38
@algomaster99 algomaster99 mentioned this pull request Jan 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@algomaster99