Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0 #10

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Version 2.0 #10

wants to merge 12 commits into from

Conversation

SpyrosRoum
Copy link
Owner

@SpyrosRoum SpyrosRoum commented Feb 25, 2022

Whole project was re-written in axum; the api remains the same, the executable doesn't take command line arguments anymore but it uses env variables entirely

ToDo

  • Update README
  • Introduce tests
    This will need a change in the structure of the project to accommodate easy testing
  • Swap log for tracing
    • Improve the number and the quality of the logs
    • Use TraceLayer from `tower-http
  • Settle on a way to configure the app. With Axum rewrite #9 I made all of configuration to happen with env variables exclusively but maybe a file would be good? I don't think I will bring back the old cli configuration
    Update: env variables are enough.

@SpyrosRoum SpyrosRoum marked this pull request as draft February 25, 2022 19:24
I just realized that the way to configure it has changed, so we need 2.0.0
@SpyrosRoum SpyrosRoum changed the title Version 1.3 Version 2.0 Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant