Fix for invalid bsdiff file being created in delta package #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in the delta package which will cause the updates to fail.
anaisbetts
reviewed
Jul 10, 2017
| // file and just removing it. | ||
| File.WriteAllText(targetFile.FullName + ".diff", "1"); | ||
| using (FileStream of = File.Create(targetFile.FullName + ".bsdiff")) | ||
| { |
|
Merged with fixups in ffaf5f2, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bsdiff fails to create a file it leaves a blank .bsdiff file sitting in the delta package which will cause the updates to fail. This occurs because the BinaryPatchUtility assumes that it should always be able to read at least 32 bytes from the stream.
If you would also like a fix to the BinaryPathcUtility.Apply method to handle empty streams I am happy to create that as well, however I think this should be sufficient.
Will likely submit another PR after I track down why the creation of the delta packages is throwing a divide by zero exception on my pdb file.
Squirrel.Windows NuGet version: 1.7.6