Staged rollouts #666
Merged
Staged rollouts #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new ReleaseEntry(m.Groups[1].Value, filename, size, isDelta, baseUrl, query, stagingPercentage); | ||
| } | ||
|
|
||
| public bool IsStagingMatch(Guid? userId) |
There was a problem hiding this comment.
Some comments on how we define a staging match would be 👌.
|
@paulcbetts Maybe add Docs to that Todo? |
|
@paulcbetts if you can point me to some example code, I'll can create a doc file for you to review. |
|
|
||
| uint val = BitConverter.ToUInt32(userId.Value.ToByteArray(), 12); | ||
|
|
||
| double percentage = ((double)val / (double)UInt32.MaxValue); |
There was a problem hiding this comment.
It seems to me, that in the absence of tracking actual downloads/installs, it is just assuming an even distribution of guid-to-integer-conversions? So, a hopeful approximation?
There was a problem hiding this comment.
We create the GUID in a Weird Way by taking random bytes that is more likely to ensure a random distribution, it's not just Guid.Create(). That being said, I am not a statistician, but it doesn't really matter so much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements staged rollouts, where a certain percentage of your users will get the newest version of your app.
We do this by adding a magic comment to the RELEASES file - unfortunately, because of a bug in the syntax Regex in existing Squirrel.Windows versions, we have to write this in a super ugly way:
Note that there is no space between the filesize and the comment. In the future, you'll able to put a space there of course :)
TODO: