-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds jasmine #978
adds jasmine #978
Conversation
related #926 |
Thanks for the PR! Since we can't test it via github actions, I'd like to test it locally before we deploy the image. Do you have some test files and some example commands I should use? |
https://downloads.pacbcloud.com/public/Sequel-II-CpG-training/CCS/methylated/
@erinyoung the file is 18G. I tried to use this data with a staged test but failed because of the cache size. As an alternative to an external test, we can put a downsampled test file to github which will be ~30K for 1 read or ~300K for 10 reads. What do you think? |
I think a downsamples bam file would be great. We currently have some fastq and bam files in https://github.com/StaPH-B/docker-builds/tree/master/tests. You can put your test files there or in the jasmine subdirectory. |
I removed the original file in the downsampling stage and it worked. I am leaving this image like this for now. If I hit a similar problem, I will add a test file next time. |
The test works great!
|
@erinyoung I have added the pbdk version. I think this is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge too
You can check the status of the deploy here: https://github.com/StaPH-B/docker-builds/actions/runs/9198414344 Thank you for putting this together! |
PacBio movie files with kinetics are too big for tests. I couldn't find a downsampled test data. So, the test stage only calls jasmines' help. PacBio distributes this as pbjasmine.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)