Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

love.js #50

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

love.js #50

wants to merge 15 commits into from

Conversation

qixils
Copy link
Contributor

@qixils qixils commented Sep 15, 2023

Currently runs and works about as well as love.js currently allows (which is... not amazingly... though theoretically some of the remaining issues should be possible to workaround)

todo:

  • Seemingly due to an issue with love.js and browsers disabling audio before the user clicks, the game will explode if the intro is allowed to play out in full.
    • Worked around by skipping the sound when love.system.getOS() == "Web"
  • Under -compatibility mode[citation needed], threads are disabled which causes music loading to fail and hang.
    • Replaced the call to Channel:demand with Channel:pop, and moved some music loading code out of the thread and into musicloader.lua so the main thread can load music directly if necessary.
  • Shaders should be updated to use stricter typing. Currently their functions are very lazily disabled (made all functions no-op)
  • When in game/unpaused, mouse needs to be locked to prevent right clicking opening the browser's usual right click menu
    • Seems to only affect Firefox, and only when also holding some keys on the keyboard
    • Despite the claims of the love.js readme, love.mouse.setGrabbed does not seem to have any effect
  • love.audio.pause() does nothing; see love.audio.stop() without arguments causes an error Davidobot/love.js#7
  • love.audio.stop() crashes; see love.audio.stop() without arguments causes an error Davidobot/love.js#7
  • Add build to GitHub workflow
    • Publish to GH Pages?
    • npx love.js.cmd -t Mari0 -c mari0.love outdir

Closes #28

Overall I think I agree with what Maurice last said on love.js, it still isn't quite there yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential web build?
1 participant