-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
love.js #50
Draft
qixils
wants to merge
15
commits into
Stabyourself:master
Choose a base branch
from
qixils:lovejs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
love.js #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently runs and works about as well as love.js currently allows (which is... not amazingly... though theoretically some of the remaining issues should be possible to workaround)
todo:
Seemingly due to an issue with love.js and browsers disabling audio before the user clicks, the game will explode if the intro is allowed to play out in full.love.system.getOS() == "Web"
Under-c
ompatibility mode[citation needed], threads are disabled which causes music loading to fail and hang.Channel:demand
withChannel:pop
, and moved some music loading code out of the thread and into musicloader.lua so the main thread can load music directly if necessary.love.mouse.setGrabbed
does not seem to have any effectlove.audio.pause()
does nothing; see love.audio.stop() without arguments causes an error Davidobot/love.js#7love.audio.stop()
crashes; see love.audio.stop() without arguments causes an error Davidobot/love.js#7npx love.js.cmd -t Mari0 -c mari0.love outdir
Closes #28
Overall I think I agree with what Maurice last said on love.js, it still isn't quite there yet...