feat: added ability to override mirai parsers and action_parsers. #81
Conversation
|
Hey @khanjasir90, The analyze check is failing due to an unused import. Please check it. https://github.com/BuildMirai/mirai/actions/runs/12608379968/job/35142662480?pr=81 |
| @@ -16,24 +16,14 @@ class MiraiRegistry { | |||
|
|
|||
| bool register(MiraiParser parser) { | |||
There was a problem hiding this comment.
@khanjasir90 Can we add an optional param called "bool override". And the parser will be overridden only of the value is true.
There was a problem hiding this comment.
Sure, added the same @divyanshub024
| return true; | ||
| } | ||
| _miraiActionParsers[type] = parser; | ||
| return true; | ||
| } | ||
|
|
||
| Future<dynamic> registerAll(List<MiraiParser> parsers) { |
There was a problem hiding this comment.
Also, please add the same logic to registerAll and registerAllActions functions.
There was a problem hiding this comment.
Update the registerAll and update registerAllActions functions with the same logic
|
Hey @khanjasir90, There is some formatting issue. Can you please run |
Description
Related Issues
Closes #17
Type of Change