Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): add CCPA icons #370

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat(icon): add CCPA icons #370

merged 5 commits into from
Jan 27, 2025

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Jan 24, 2025

STACKS-714


This PR adds the CCPA icon.

Screenshot

image

Open questions

  • There no precedence for including naming of color and monochromatic versions of the same icon. I went with Alt for the monochromatic one, but I'm unsure if this is the optimal approach. I'd like an opinions of what seems like the most sensible naming for these icons if you got them.

cc @CGuindon

@dancormier dancormier added the icon PR adds/edits/removes an icon or Issue is concerning an icon label Jan 24, 2025
@dancormier dancormier requested a review from giamir January 24, 2025 21:04
@CGuindon
Copy link
Contributor

@dancormier I think using Alt is fine. This will likely only ever get used in the footer and maybe some other legal page or something.

@abovedave Any preference or thoughts?

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if I fully understand the purpose of the icon filled with blu here.

Screenshot 2025-01-27 at 10 19 50

If the goal is to get the svg to inherit the color of the parent element's background then we should probably stick with one icon supporting current color like we do in the Stacks Logos repo (see PR).

I took the liberty to make a commit in this PR that introduces the same mechanism @abovedave introduced in Stacks Logos to easily highlight the fill="currentColor" part of an SVG (that should be easily revertible if we decide to do something different).

Screenshot 2025-01-27 at 10 19 04

We need a designer now to help us out adjust the icon in Figma accordingly to use currentcolor. @CGuindon @abovedave perhaps you could sync and double check if we can use here the same approach we use in Stacks Logos. Thank you. 😊

@abovedave abovedave self-requested a review January 27, 2025 16:28
@dancormier dancormier merged commit b49bb65 into production Jan 27, 2025
3 checks passed
@dancormier dancormier deleted the STACKS-714/ccpa-icons branch January 27, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon PR adds/edits/removes an icon or Issue is concerning an icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants