fix(linters): address all existing violations in the codebase #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exclude less files from prettier formatting since running the formatter was breaking the syntax
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dancormier
reviewed
Dec 1, 2022
There was a problem hiding this comment.
I like it! Feels good to see our codebase tend towards consistency. Thanks for picking this up!
I had a question or two, so I'm not explicitly approving it, but if my questions don't require any changes, feel free to merge. I know this will create a handful of conflicts with existing branches, so I understand the urgency here.
Once this is merged, I'll take a minute to update my outstanding branches.
|
Thanks @dancormier for the review (and for a great catch!). Will merge the PR now into develop and rebase the testing branch accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes existing issues with our linters and formatters.
Running
npm run lintnow executesstylelint,eslintandprettier --checkconcurrently.All checks are now passing in preparation for the testing PR where we will start running linters (as well as tests) in a github workflow.
Prettier and Style Formatting
I have experienced a strange behavior running prettier against our less files: the formatter will break the style syntax.
For the time being I have decided to exclude less files from prettier since they already get some format check with stylelint. We might want to revisit this decision though.