Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(opacity): bump disabled opacity to 0.55 #1860

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Nov 22, 2024

STACKS-590


This PR does one thing: changes the value of the disabled custom properties used across Stacks from 0.5 to 0.55. That is all!

Acceptance Criteria

  • Bump the opacity for disabled button to 55%
  • Explore if we can test disabled button for a11y color contrast in Stacks Classic Moved to

Before

Screenshot 2024-11-28 at 8 23 27 AM

After (very subtle)

Screenshot 2024-11-28 at 8 25 07 AM

How to test

  • Go to any docs page that shows examples of disabled elements (buttons, inputs)
  • Verify that the elements opacity value is now set to 0.55 (via the --_o-disabled-static or --_o-disabled custom property)

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 764be9b
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/675377b5e4a07500083ddd84
😎 Deploy Preview https://deploy-preview-1860--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the a11y tests pass, this LGTM — confirmed it's bumped to 55%

@dancormier dancormier marked this pull request as ready for review December 6, 2024 22:22
@dancormier dancormier merged commit 76de9ff into develop Dec 6, 2024
11 checks passed
@dancormier dancormier deleted the STACKS-590/bump-disabled-opacity-to-0-55 branch December 6, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants