-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update_dashboard
#76: Correct Payload
#77
Fix update_dashboard
#76: Correct Payload
#77
Conversation
Turns out during my testing, I forgot to have a permutation where I updated the permissions of a dashboard. Discovered the payload is malformed because of a lack of post-processing in the `jira` lib (this is as intended). This PR fixes the issue. * Update keys in payload dict for `update_dashboard` action from `edit_permissions/share_permissions` to `editPermissions/sharePermissions` to make the `jira` API happy.
@floatingstatic Looks like there is something busted with the CI. I wonder if there was a change to the reusable workflow upstream at some point. Anyway, it's blocking this PR.
|
@floatingstatic @nzlosh I wonder if maybe the issue is with the cache the github action is using? This error is pretty bizarre considering tests passed for the last PR and afaict there hasn't been anything related to this changed upstream in quite some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay. Approving the changes. I will see if I can hunt down a solution for the CI issue. I looked briefly at the CI repo as well and see nothing recent that would impact this. It also strikes me as odd that this worked prior to merging the last PR but do not see how this would be connected at first glance.
@jpavlav i cleared the actions cache and was able to get this to pass. Thanks for the suggestion. Merging. |
Turns out during my testing, I forgot to have a permutation where I updated the permissions of a dashboard. Discovered the payload is malformed because of a lack of post-processing in the
jira
lib (this is as intended). This PR fixes the issue.update_dashboard
action fromedit_permissions/share_permissions
toeditPermissions/sharePermissions
to make thejira
API happy.