Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification in the descriptions and actions along with tests. #30

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ankitaOrch
Copy link

Updated the descriptions of all parameters in the pack that take a JSON input to use double-quotes. The descriptions currently give examples with single-quotes, which do not work in the ST2 UI.
Also, Insert, Update, and Delete actions in the SQL pack only search the 'dbo' schema. Added schema parameter to support different schemas in the actions and modified to accommodate triggers.
Also modified the tests to accommodate the schema change.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants