Fix CentOS/Amazon AMI build Dockerfiles. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove stray `yum update` commands - Redirect CentOS 8 mirrors to the vault - Fix repository name on CentOS 8
qingling128
approved these changes
Mar 29, 2022
| @@ -1,8 +1,7 @@ | |||
| FROM amazonlinux:2016.09 | |||
|
|
|||
| ADD http://ftp.tu-chemnitz.de/pub/linux/dag/redhat/el6/en/x86_64/rpmforge/RPMS/rpm-macros-rpmforge-0-6.el6.rf.noarch.rpm . | |||
| RUN yum -y update \ | |||
There was a problem hiding this comment.
Just curious: Is yum -y update automatically triggered, or just not needed?
There was a problem hiding this comment.
Unlike apt-get update, which simply refreshes the repo contents, yum update upgrades all installed packages (similar to apt-get upgrade), so it was the wrong thing to do. The refresh of the repos (similar to apt-get update) happens automatically with yum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yum updatecommandsSee also GoogleCloudPlatform/google-fluentd#377