Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bundle libcurl in RPM builds. #142

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Don't bundle libcurl in RPM builds. #142

merged 3 commits into from
Oct 10, 2023

Conversation

igorpeshansky
Copy link
Member

This will link against the system libcurl on all platforms.

b/303836056

qingling128
qingling128 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (See manual tests in the internal ticket)

@igorpeshansky igorpeshansky merged commit f5f10cf into master Oct 10, 2023
@igorpeshansky igorpeshansky deleted the igorpeshansky-no-libcurl-bundle branch October 10, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

@sophieyfang sophieyfang sophieyfang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorpeshansky @qingling128 @sophieyfang