Support counter metrics with the _total suffix. #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenYCChou
suggested changes
Aug 12, 2019
|
Updated, PTAL |
…ginal metric name despite using the truncated name for metadata lookup.
bmoyles0117
force-pushed
the
support-prometheus-counters-with-total-suffix
branch
from
ae50bd2 to
b719493
Compare
bmoyles0117
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should resolve the bug discovered in #144 where metrics introduced in Python3 client librarie have adopted the new standard for tracking counter creation time with
_totaland_createdsuffixes.