Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ran go mod vendor #188

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Ran go mod vendor #188

merged 1 commit into from
Oct 17, 2019
+163 −9,200

Conversation

jkohen
Copy link
Contributor

@jkohen jkohen commented Oct 17, 2019

It drops some unused files. Makes my next PR leaner (because I had to vendor new modules).

@jkohen jkohen requested a review from StevenYCChou October 17, 2019 20:27
@jkohen jkohen self-assigned this Oct 17, 2019
StevenYCChou
StevenYCChou approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@StevenYCChou StevenYCChou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning up and making the lines in modules.txt sorted.

@jkohen
Copy link
Contributor Author

jkohen commented Oct 17, 2019

LGTM. Thanks for cleaning up and making the lines in modules.txt sorted.

Thank the go mod developers for the sorting :)

@jkohen jkohen merged commit 7df8d3e into master Oct 17, 2019
@jkohen jkohen deleted the mod_update branch October 17, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenYCChou StevenYCChou

Assignees

@jkohen jkohen

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkohen @StevenYCChou @googlebot