Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compilation step in main_test. #198

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Removed compilation step in main_test. #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b78a5f1
Removed compilation step in main_test.
jkohen Nov 15, 2019
6bd9668
Update main_test.go
jkohen Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions cmd/stackdriver-prometheus-sidecar/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,9 @@ package main
import (
"bytes"
"errors"
"flag"
"fmt"
"net/http"
"os"
"os/exec"
"path/filepath"
"testing"
"time"

Expand All @@ -38,31 +35,12 @@ import (
var promPath string

func TestMain(m *testing.M) {
flag.Parse()
if testing.Short() {
if os.Getenv("RUN_MAIN") == "" {
jkohen marked this conversation as resolved.
Show resolved Hide resolved
// Run the test directly.
os.Exit(m.Run())
}
// On linux with a global proxy the tests will fail as the go client(http,grpc) tries to connect through the proxy.
os.Setenv("no_proxy", "localhost,127.0.0.1,0.0.0.0,:")

var err error
promPath, err = os.Getwd()
if err != nil {
fmt.Printf("can't get current dir :%s \n", err)
os.Exit(1)
}
promPath = filepath.Join(promPath, "prometheus")

build := exec.Command("go", "build", "-o", promPath)
output, err := build.CombinedOutput()
if err != nil {
fmt.Printf("compilation error :%s \n", output)
os.Exit(1)
}

exitCode := m.Run()
os.Remove(promPath)
os.Exit(exitCode)
main()
StevenYCChou marked this conversation as resolved.
Show resolved Hide resolved
}

// As soon as prometheus starts responding to http request should be able to accept Interrupt signals for a gracefull shutdown.
Expand All @@ -71,7 +49,8 @@ func TestStartupInterrupt(t *testing.T) {
t.Skip("skipping test in short mode.")
}

prom := exec.Command(promPath, "--stackdriver.project-id=1234", "--prometheus.wal-directory=testdata/wal")
prom := exec.Command(os.Args[0], "--stackdriver.project-id=1234", "--prometheus.wal-directory=testdata/wal")
prom.Env = append(os.Environ(), "RUN_MAIN=1")
var bout, berr bytes.Buffer
prom.Stdout = &bout
prom.Stderr = &berr
Expand Down