Add ability to specify scopes for Google Services when using Google Sign In #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilledStacks
requested changes
Mar 26, 2024
| @@ -17,7 +17,7 @@ class FirebaseAuthenticationService { | |||
| final Logger? log; | |||
|
|
|||
| final firebaseAuth = FirebaseAuth.instance; | |||
| final GoogleSignIn _googleSignIn = GoogleSignIn(); | |||
| GoogleSignIn? _googleSignIn; | |||
There was a problem hiding this comment.
What's the benefit of going to a nullable GoogleSignIn object and not using late?
| @@ -35,7 +35,7 @@ class FirebaseAuthenticationService { | |||
| Future<UserCredential> _signInWithCredential( | |||
| AuthCredential credential, | |||
| ) async { | |||
| return firebaseAuth.signInWithCredential(credential); | |||
| return await firebaseAuth.signInWithCredential(credential); | |||
There was a problem hiding this comment.
We do we need to await here if the calling function should be awaiting the future?
| @@ -597,17 +599,20 @@ class FirebaseAuthenticationResult { | |||
|
|
|||
| /// Firebase additional user information | |||
| final AdditionalUserInfo? additionalUserInfo; | |||
| final String? oAuthAccessToken; | |||
FilledStacks
requested changes
Mar 27, 2024
pubspec.yaml
Outdated
| @@ -2,7 +2,7 @@ name: stacked_firebase_auth | |||
| description: A service class that provides Firebase Authentication Functionality on a single api | |||
| version: 2.20.0 | |||
| homepage: https://stacked.filledstacks.com/ | |||
| repository: https://github.com/Stacked-Org/firebase_auth.git | |||
| repository: https://github.com/pmmucsd/firebase_auth.git | |||
There was a problem hiding this comment.
This change will not go in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass in a list of scopes and returns the oAuth access token with the FirebaseAuthenticationResult. This enables developers to use this library to request access to Google Services like Drive and Gmail in the signup flow.