Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose setCurrentWebPageIndex on IndexTrackingStateHelper #976

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

ferrarafer
Copy link
Contributor

No description provided.

* Add RouterServiceInterface to Stacked package

* Add setCurrentWebPageIndex method to IndexTrackingViewModel

* Update cupertino_icons on example apps

* Sort routes to match BottomNavigation items order

* Call setCurrentWebPageIndex on Class Constructor

Allows to set the index of the Bottom Navigation Bar using the current
route at Web Platform when app starts from scratch which means there is
no state for the currentIndex property to track the selected button.

* Refactor IndexTrackingViewModel
* Add RouterServiceInterface to Stacked package

* Add setCurrentWebPageIndex method to IndexTrackingViewModel

* Update cupertino_icons on example apps

* Sort routes to match BottomNavigation items order

* Call setCurrentWebPageIndex on Class Constructor

Allows to set the index of the Bottom Navigation Bar using the current
route at Web Platform when app starts from scratch which means there is
no state for the currentIndex property to track the selected button.

* Update router_example to test InitializableSingleton

Update example

Squash
@github-actions
Copy link

LCOV of commit 012891f during Test Package #58

Summary coverage rate:
  lines......: 7.6% (282 of 3714 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                             |Lines       |Functions  |Branches    
  Filename                                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================================
  lib/src/view_models/base_view_models.dart                                  |48.2%     56|    -     0|    -      0
  lib/src/view_models/helpers/index_tracking_state_helper.dart               | 100%     24|    -     0|    -      0
  lib/src/view_models/index_tracking_viewmodel.dart                          | 0.0%      2|    -     0|    -      0

@ferrarafer ferrarafer marked this pull request as ready for review June 22, 2023 17:36
@ferrarafer ferrarafer changed the title chore: pre-release fix: expose setCurrentWebPageIndex on IndexTrackingStateHelper Jun 22, 2023
@ferrarafer ferrarafer merged commit 2057589 into master Jun 22, 2023
@ferrarafer ferrarafer deleted the pre-release branch June 22, 2023 17:49
FilledStacks pushed a commit that referenced this pull request Jun 22, 2023
## [3.4.1](v3.4.0...v3.4.1) (2023-06-22)

### Bug Fixes

* expose setCurrentWebPageIndex on IndexTrackingStateHelper ([#976](#976)) ([2057589](2057589)), closes [#973](#973) [#967](#967)
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 3.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants