Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Education Video fetching failure with content unavailable view. #84

Closed
1 task done
nriedman opened this issue Sep 3, 2024 · 2 comments · Fixed by #94
Closed
1 task done

Handle Education Video fetching failure with content unavailable view. #84

nriedman opened this issue Sep 3, 2024 · 2 comments · Fixed by #94
Labels
enhancement New feature or request

Comments

@nriedman
Copy link
Contributor

nriedman commented Sep 3, 2024

Problem

Right now, if we fail to fetch the educational videos from firestore (for if there are no videos in firestore), we show an essentially empty view in the Education tab. Instead, we should show a ContentUnavailableView.

Solution

Add an if statement that will either show the VideoList if the VideoManager is not empty, and a ContentUnavailableView otherwise. Within the VideoList, if a videoCollection is empty (i.e. the section has no videos), consider not showing the VideoListSection.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@nriedman nriedman added the enhancement New feature or request label Sep 3, 2024
@PaulGoldschmidt
Copy link
Collaborator

I would take a look into this issue and possibly implement this along with issue #57, as I assume the solution to both issues should be nearly identical in their implementation of the ContentUnavailableView 🚀

@nriedman
Copy link
Contributor Author

nriedman commented Sep 7, 2024

Great idea! Fyi handling empty content has already been taken care of in the Heart Health view in a previous PR (I meant to close #57), so Education is the main place where this will be necessary. Feel free to adjust/add empty content handling in other views if you notice any inconsistencies! 🚀

PaulGoldschmidt added a commit to PaulGoldschmidt/ENGAGE-HF-iOS that referenced this issue Sep 9, 2024
…nce with issue StanfordBDHG#84:

Update Education view to handle empty video collections and modification of VideoList to display message when no videos are available
PaulGoldschmidt added a commit to PaulGoldschmidt/ENGAGE-HF-iOS that referenced this issue Sep 13, 2024
…nce with issue StanfordBDHG#84:

Update Education view to handle empty video collections and modification of VideoList to display message when no videos are available
@pauljohanneskraft pauljohanneskraft linked a pull request Sep 25, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants