Fix state handling on logout, always display nearby devices button, remove Mock Web Service #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 85.71% 85.74% +0.03%
==========================================
Files 69 68 -1
Lines 2505 2474 -31
==========================================
- Hits 2147 2121 -26
+ Misses 358 353 -5
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix state handling on logout, always display nearby devices button, remove Mock Web Service
♻️ Current situation & Problem
The app doesn't reset state that is only maintained for an authenticate used account. This causes some permission errors to pop up.
Additionally, the PR removes the MockWebService and some FeatureFlags that weren't used anymore or don't make sense anymore.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: