Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for tiles view #56

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 24, 2024

Improve accessibility for tiles view

♻️ Current situation & Problem

The current TilesView requires a lot of navigation within Voice Over. This PR iterates on this designs and makes every tile a single accessibility element instead of dividing it up into its children. This greatly simplifies navigation with VoiceOver.

Additionally, we added isHeader traits for the SelectedPatientLabel and for the Patient name in the PatientInformation view.

⚙️ Release Notes

  • Accessibility improvements.

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.36%. Comparing base (a4451e6) to head (cd78e40).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   84.25%   84.36%   +0.11%     
==========================================
  Files          94       94              
  Lines        3301     3330      +29     
==========================================
+ Hits         2781     2809      +28     
- Misses        520      521       +1     
Files Coverage Δ
NAMS/Patients/CurrentPatientLabel.swift 100.00% <100.00%> (ø)
NAMS/Patients/PatientInformation.swift 98.81% <100.00%> (+0.02%) ⬆️
NAMS/Patients/Tasks/ScreeningTask.swift 100.00% <100.00%> (ø)
NAMS/Tiles/MeasurementTile.swift 100.00% <100.00%> (ø)
NAMS/Tiles/ScreeningTile.swift 100.00% <100.00%> (ø)
NAMS/Tiles/ScreeningTileHeader.swift 97.96% <100.00%> (+0.05%) ⬆️
NAMS/Tiles/SimpleTile.swift 96.08% <94.88%> (+1.35%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4451e6...cd78e40. Read the comment docs.

@Supereg Supereg merged commit cbab628 into main Feb 24, 2024
8 checks passed
@Supereg Supereg deleted the feature/tiles-accessibility-improvements branch February 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant