Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Turn on the default starcache UT switch to build the starrocks unittests with datacache. #34638

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[Enhancement] Turn on the default starcache UT switch to build the starrocks unittests with datacache. #34638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gensrc/thrift/InternalService.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ struct TPlanFragmentExecParams {
// To enable pass through chunks between sink/exchange if they are in the same process.
52: optional bool enable_exchange_pass_through

53: optional map<Types.TPlanNodeId, map<i32, list<TScanRangeParams>>> node_to_per_driver_seq_scan_ranges
53: optional map<Types.TPlanNodeId, map<i32, list<TScanRangeParams>>> node_to_per_driver_seq_scan_ranges

54: optional bool enable_exchange_perf

Expand Down
4 changes: 1 addition & 3 deletions run-be-ut.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,8 @@ if [ "${USE_STAROS}" == "ON" ]; then
export STARLET_INSTALL_DIR
fi

# Temporarily keep the default behavior same as before to avoid frequent thirdparty update.
# Once the starcache version is stable, we will turn on it by default.
if [[ -z ${WITH_STARCACHE} ]]; then
WITH_STARCACHE=${USE_STAROS}
WITH_STARCACHE=ON
fi

${CMAKE_CMD} -G "${CMAKE_GENERATOR}" \
Expand Down