Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] add some defensive codes to table metrics #55839

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Feb 12, 2025

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/9217

Add some defensive code for table metrics:

  1. under shared_data mode, if the tableId cannot be found from the shard property, return a default table id to avoid crash.
  2. In some scenarios, the corresponding table id may not be found in _metrics_map (for example, data load and drop tablet concurrently, dropping tablets occurs first, causing metrics to be cleared). in such cases, we can return a blackhole metrics to prevent the subsequent operations works well.
  3. When there are so many tables, metrics/ interfaces may have to return a lot of table metrics, resulting in too large response body. I chose to add a configuration to control whether to return table metrics.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@silverbullet233 silverbullet233 requested review from a team as code owners February 12, 2025 08:21
@github-actions github-actions bot added the 3.4 label Feb 12, 2025
@silverbullet233 silverbullet233 changed the title [BugFix] add some protective codes to table metrics [BugFix] add some defensive codes to table metrics Feb 13, 2025
murphyatwork
murphyatwork previously approved these changes Feb 13, 2025
@silverbullet233 silverbullet233 enabled auto-merge (squash) February 13, 2025 07:39
Signed-off-by: silverbullet233 <[email protected]>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 5 / 16 (31.25%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/staros_worker.cpp 0 9 00.00% [87, 88, 92, 93, 94, 95, 96, 97, 98]
🔵 be/src/http/action/metrics_action.cpp 1 3 33.33% [132, 297]
🔵 be/src/util/table_metrics.h 4 4 100.00% []

@kangkaisen kangkaisen disabled auto-merge February 14, 2025 06:50
@kangkaisen kangkaisen merged commit eb52609 into StarRocks:main Feb 14, 2025
46 of 47 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 14, 2025
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit eb52609)
liaowanyou pushed a commit to liaowanyou/starrocks that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants