Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oggdude importer does not import navicomputer status or backup hyperdrive for vehicles. #1537

Closed
grimsdalee opened this issue May 31, 2024 · 2 comments
Closed

Oggdude importer does not import navicomputer status or backup hyperdrive for vehicles. #1537

grimsdalee opened this issue May 31, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
1.901

Comments

@grimsdalee
Copy link

Just set up a fresh v12 server with a new SWFFG v1.9 world.
Imported the Oggdude dataset & discovered that none of the ships that had navicomputer ticked have imported that setting into SWFFG.

This is also the case for the backup hyperdrive number - see below:

image

image
@grimsdalee
Copy link
Author

I have also spotted that the default for the primary hyperdrive sets to 1, even if a imported ship has no hyperdrive:

image

image

@wrycu wrycu added the enhancement New feature or request label Jun 3, 2024
@wrycu wrycu added this to the 1.901 milestone Jun 3, 2024
wrycu added a commit that referenced this issue Jun 12, 2024
@wrycu
fix(vehicle): hyperdrive import
6b09e97 
* import primary/secondary hyperdrive values (set to null if not present)
* import navicomputer value

#1537
wrycu added a commit that referenced this issue Jun 12, 2024
@wrycu
fix(vehicle): hyperdrive import
0f2ec8f 
* import primary/secondary hyperdrive values (set to null if not present)
* import navicomputer value

#1537
@wrycu
Copy link
Collaborator

wrycu commented Jun 12, 2024

Done, will be released in 1.901. Thanks for the report.

@wrycu wrycu closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.901
Development

No branches or pull requests
2 participants
@wrycu @grimsdalee