Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setback in rollDice #1719

Closed
TeddyBears opened this issue Oct 12, 2024 · 1 comment
Closed

Remove setback in rollDice #1719

TeddyBears opened this issue Oct 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@TeddyBears
Copy link
Contributor

TeddyBears commented Oct 12, 2024

Describe the bug
If I do a test for a skill with some remove setback dices these one don't remove the setback

To Reproduce
Do a check from crew skill of a vehicle. I don't know why from actor sheet the remove setback are not added in the dice roller

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image
image

Desktop (please complete the following information):

  • Foundry Version: v12.327
  • System Version: 1.903
  • Hosted on Forge: No

Solution
In pool.js file into the function renderDiceExpression line 219
if I add the follwing code before let dicePool ... it was fixed :

this.setback = Math.max(0,this.setback - this.remsetback);
@wrycu
Copy link
Collaborator

wrycu commented Nov 7, 2024

This is by design. Many remove setbacks are situational. It's up to the user to apply them.

@wrycu wrycu closed this as completed Nov 7, 2024
@wrycu wrycu added the wontfix This will not be worked on label Nov 7, 2024
@wrycu wrycu self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants