Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill check from actor does not add the remove setback in the Roll dice dialog #1720

Closed
TeddyBears opened this issue Oct 12, 2024 · 2 comments · Fixed by #1726
Closed

Skill check from actor does not add the remove setback in the Roll dice dialog #1720

TeddyBears opened this issue Oct 12, 2024 · 2 comments · Fixed by #1726
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TeddyBears
Copy link
Contributor

Describe the bug
From actor sheet when i click on dice preview to do a skill check the remove setback dices are not added in the dialog box
If I do the check skill from the crew of a vehicle the remove setback dices are added
In both case the remove setback dices are not remove from the setback added in the roll dice Dialog (see issue #1719)

To Reproduce

  1. Open actor sheet
  2. Click on dices preview close to a skill

Expected behavior
have same feature than for the crew. It will be usefull that remove setback dices are automatically used in a dice roll

Screenshots
image

Desktop (please complete the following information):

  • Foundry Version: v12.327
  • System Version: 1.903
  • Hosted on Forge: No
@TeddyBears TeddyBears added the bug Something isn't working label Oct 12, 2024
@wrycu
Copy link
Collaborator

wrycu commented Nov 7, 2024

This is by design. Many remove setbacks are situational. It's up to the user to apply them.

@wrycu wrycu closed this as completed Nov 7, 2024
@wrycu wrycu added the wontfix This will not be worked on label Nov 7, 2024
@wrycu wrycu self-assigned this Nov 7, 2024
@wrycu
Copy link
Collaborator

wrycu commented Nov 7, 2024

Oops, confused this and #1719. That's a bug. Will take a look :0

@wrycu wrycu reopened this Nov 7, 2024
@wrycu wrycu removed the wontfix This will not be worked on label Nov 7, 2024
@wrycu wrycu added this to the 1.904 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants