Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(actor): update top-level info #1322

Merged
merged 1 commit into from
Jan 14, 2024
Merged

refactor(actor): update top-level info #1322

merged 1 commit into from
Jan 14, 2024

Conversation

wrycu
Copy link
Collaborator

@wrycu wrycu commented Jan 13, 2024

  • moves force powers and specializations into the section with species, career, and specialization for characters and adversaries

#713

* moves force powers and specializations into the section with species, career, and specialization for characters and adversaries

#713
@wrycu wrycu requested a review from Esrin January 13, 2024 01:16
@Esrin
Copy link
Collaborator

Esrin commented Jan 14, 2024

Can I see some screenshots of some more scenarios for this?

I'm a little concerned it might get a bit cluttered as characters can often have many force powers by mid-to-high experience levels. Having the nice easy talents page view where you can expand and collapse force powers to show more / less info when needed can be pretty useful when playing such characters.

How does this look by the time a character has a half dozen force powers?

@wrycu
Copy link
Collaborator Author

wrycu commented Jan 14, 2024

NVIDIA_Share_2024-01-13_16-14-43

Example has six (which is more than I've had in any game.)

@Esrin
Copy link
Collaborator

Esrin commented Jan 14, 2024

Also some screenshots confirming it works fine in V1 sheets as well as V2 is probably worthwhile.

If I'm reading the changes right, we still have the talents view with the expandable / collapsible bits so I think this is fine as long as it's an optional extra. Maybe we should make it configurable in sheet options?

@wrycu
Copy link
Collaborator Author

wrycu commented Jan 14, 2024

It looks the same in v1 and v2.

(but, for reference)

image

@Esrin
Copy link
Collaborator

Esrin commented Jan 14, 2024

Looked a bit closer and I think you've already tied it to the existing showForcePool sheet option so seems fine to me.

I think this will be a bit messy for some Force & Destiny characters personally but I'm happy to go with it for now, although I think people might end up wanting it configurable separately in the long run.

@wrycu
Copy link
Collaborator Author

wrycu commented Jan 14, 2024

It is tied to the showForcePool option, yeah. Happy to add an option if people ask for it.

@Esrin Esrin merged commit 3200c99 into main Jan 14, 2024
@Esrin Esrin deleted the actor-sheet_713 branch January 14, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants