Xp spending #1398
Merged
Xp spending #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provides right-click menus to purchase skill ranks, talents, and FP/SA upgrades * keeps a log of spent (and granted) XP #1356
* adds the ability to specify specializations and signature abilities for a career * this will be used to present them for purchase #1356
* adds the ability to purchase specializations, signature abilities, and force powers * compendiums to search can be set in the settings * all spending logs to a log * buying these is started by clicking the appropriate header in a character sheet * signature abilities now have a base cost (defaulting to 0) #1356
* fix career sheet height to properly show all specializations and signature abilities
* improve importer to retrieve the following information:
* force power base cost
* force power required force rating
* signature ability base power cost
* imported careers now associate with specializations and signature abilities automatically
#1356
Esrin
previously approved these changes
Apr 6, 2024
| @@ -189,14 +190,14 @@ export default class DataImporter extends FormApplication { | |||
| promises.push(OggDude.Import.Armor(xmlDoc, zip)); | |||
| promises.push(OggDude.Import.Talents(xmlDoc, zip)); | |||
| promises.push(OggDude.Import.ForcePowers(xmlDoc, zip)); | |||
| promises.push(OggDude.Import.SignatureAbilities(xmlDoc, zip)); | |||
| //promises.push(OggDude.Import.SignatureAbilities(xmlDoc, zip)); | |||
There was a problem hiding this comment.
Is this meant to be commented out?
There was a problem hiding this comment.
It should be removed, but I don't think it does a ton either way. It's been re-added further down the file (line 222)
|
@Esrin since there were conflicts, I had to resolve them and it needs another review. |
Esrin
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/StarWarsFoundryVTT/StarWarsFFG/wiki/new%E2%80%90features%E2%80%90v1.809