Ethos #210
Open
Ethos #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jptissot
reviewed
Apr 22, 2021
| "name": "ContentDefinition", | ||
| "ContentTypes": [ | ||
| { | ||
| "Name": "Persona", |
There was a problem hiding this comment.
I don't think this is required since you are creating the types with the code Migration
jptissot
reviewed
Apr 22, 2021
| @@ -7,7 +7,10 @@ | |||
|
|
|||
| <head> | |||
| <link href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900" rel="stylesheet"> | |||
|
|
|||
|
|
|||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/knockout/3.4.0/knockout-min.js"></script> | |||
There was a problem hiding this comment.
Please do not add scripts to the layout, add them to your templates
jonlamdev
added
the
wait-to-merge
jptissot
removed
the
wait-to-merge
jptissot
reviewed
Jul 6, 2021
| @@ -15,6 +15,7 @@ | |||
| <ProjectReference Include="..\StatCan.OrchardCore.Security\StatCan.OrchardCore.Security.csproj" PrivateAssets="none" /> | |||
|
|
|||
| <!-- Modules --> | |||
| <ProjectReference Include="..\..\Modules\StatCan.OrchardCore.DisplayHelpers\StatCan.OrchardCore.DisplayHelpers.csproj" PrivateAssets="none" /> | |||
jptissot
reviewed
Jul 6, 2021
| @@ -1,48 +1,20 @@ | |||
| (function () { | |||
There was a problem hiding this comment.
I will make a PR with this change directly
MackenzieBarrett
force-pushed
the
ethos
branch
from
67f8bc1 to
88bfae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.