-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate content from radar #311
base: master
Are you sure you want to change the base?
Conversation
574b375
to
93e590e
Compare
Purple OC Radar reviewOverall
Hero
Appbar
|
src/Apps/StatCan.OrchardCore.Radar/Controllers/ListController.cs
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Controllers/ListController.cs
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Liquid/ContentItemsFilter.cs
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Controllers/ListController.cs
Outdated
Show resolved
Hide resolved
</v-col> | ||
</v-row> | ||
<v-row> | ||
{% for activity in Model.ContentItem.Content.Activities.ContentItems %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a query to get the most recent activities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query is here:
StatCan.OrchardCore/src/Apps/StatCan.OrchardCore.Radar/Views/Content-EntityCard.liquid
Line 4 in 5ee955e
{% assign entities = Queries.RecentActivitiesSQL | query: contentType: Model.ContentItem.Content.EntityCard.Type.Text, num: Model.ContentItem.Content.EntityCard.Limit.Value | list_can_view | current_culture %} |
src/Apps/StatCan.OrchardCore.Radar/Views/Content-Project.liquid
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Views/Content-Proposal.liquid
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Views/Content-Proposal.liquid
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,98 @@ | |||
const attachSorter = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sorter assumes all data is loaded client side. Might have to switch to a api call in the future.
src/Apps/StatCan.OrchardCore.Radar/Indexing/ContentPermissionsPartIndex.cs
Outdated
Show resolved
Hide resolved
src/Apps/StatCan.OrchardCore.Radar/Indexing/ContentPermissionsPartIndex.cs
Outdated
Show resolved
Hide resolved
|
||
namespace StatCan.OrchardCore.Radar.Liquid | ||
{ | ||
public class CurrentCultureFilter: ILiquidFilter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this one to the StatCan.OrchardCore.DisplayHelpers module with a more specific name. Something like filter_current_culture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved
src/Apps/StatCan.OrchardCore.Radar/Views/Content-Community.liquid
Outdated
Show resolved
Hide resolved
Change now
Things to consider for later
DNS:
|
localize app bar title
This PR migrates radar to OC.