Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate content from radar #311

Open
wants to merge 198 commits into
base: master
Choose a base branch
from
Open

Migrate content from radar #311

wants to merge 198 commits into from

Conversation

mfan127
Copy link
Collaborator

@mfan127 mfan127 commented Sep 27, 2021

This PR migrates radar to OC.

@mfan127 mfan127 linked an issue Sep 27, 2021 that may be closed by this pull request
@mfan127 mfan127 force-pushed the migrate-content-from-radar branch from 574b375 to 93e590e Compare October 8, 2021 15:14
@mfan127 mfan127 requested review from jptissot and removed request for jptissot October 8, 2021 16:28
@bmanbzan
Copy link
Contributor

bmanbzan commented Oct 13, 2021

Purple OC Radar review

Overall

  • MF: Update brand identity (radar icon) with the old Digital Innovation icon (lighthouse)
  • BB: Colours, gradients and fonts need to be reviewed (confirm via vscode liveshare)

Hero

  • BB: Font size too small? (confirm via vscode liveshare)
  • BB: FIP opacity doesn't seem to be 100% (confirm via vscode liveshare)

Appbar

  • MF: Login and language toggle buttons should be orange circles

@mfan127 mfan127 requested a review from jptissot October 19, 2021 13:25
</v-col>
</v-row>
<v-row>
{% for activity in Model.ContentItem.Content.Activities.ContentItems %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a query to get the most recent activities.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query is here:

{% assign entities = Queries.RecentActivitiesSQL | query: contentType: Model.ContentItem.Content.EntityCard.Type.Text, num: Model.ContentItem.Content.EntityCard.Limit.Value | list_can_view | current_culture %}

@mfan127 mfan127 requested a review from jptissot October 26, 2021 15:27
@@ -0,0 +1,98 @@
const attachSorter = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sorter assumes all data is loaded client side. Might have to switch to a api call in the future.


namespace StatCan.OrchardCore.Radar.Liquid
{
public class CurrentCultureFilter: ILiquidFilter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this one to the StatCan.OrchardCore.DisplayHelpers module with a more specific name. Something like filter_current_culture

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

@mfan127 mfan127 requested a review from jptissot October 28, 2021 14:53
@mfan127
Copy link
Collaborator Author

mfan127 commented Nov 29, 2021

Change now

  • Put datetime picker in dialog
  • Change height of app bar radar icon to 40px
  • Move app bar icon to the right

Things to consider for later

  • Change color scheme of text field in selected state
  • Urls for the entities

DNS:

  • digital.innovation.cloud.statcan.ca/radar
  • digital.statcan.gc.ca

@mfan127 mfan127 requested review from arnaudroy97 and removed request for jptissot November 30, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knowledge Management Application Module
3 participants