Natural_gradient #45
Open
Natural_gradient #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ujohn33 Thanks for opening the PR. What's the reason why you closed this again? |
|
Hi Alexander,
I have reopened the PR now.
I have added a few more commits since I added and I was not sure if they apply but apparently they do.
The change was that I sped up the quantile clipping by doing it with only torch avoiding nympy.
Best regards,
Evgeny
… On 13 Jan 2025, at 12:14, Alexander März ***@***.***> wrote:
@ujohn33 <https://github.com/ujohn33> Thanks for opening the PR.
What's the reason why you closed this again?
—
Reply to this email directly, view it on GitHub <#45 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMUAW2PNXUKFOWWXPOUSKE32KN7YBAVCNFSM6AAAAABU6ER3HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBWGU3DKNRYG4>.
You are receiving this because you were mentioned.
|
|
@ujohn33 Thanks for opening the PR again. Can you please add unit-tests for your changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option for training with natural gradient and gradient clipping as hyperparameter (quanitle and threshold types)