-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/nico/auth #32
Fix/nico/auth #32
Conversation
src/server.ts
Outdated
@@ -1,5 +1,5 @@ | |||
import * as dotenv from "dotenv"; | |||
dotenv.config({ path: __dirname+'/.env' }); | |||
dotenv.config(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Nico , the env is failing if we don't specify the path. Had this issue on render too and facing it locally too.
dotenv.config({ path: __dirname+'/.env' });
using dotenv like above make sure it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird :S are you using Linux? In my Windows setup it fails when we specify the path :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a new change reverting this, could you try to run this in your local? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am running Linux . I can put it in try catch block i guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will read more about it and try to fix it in https://github.com/State-Channel-4/backend/tree/feat/nico/sync-contract
Close #31
.env
not read by npm problemtypechain
contract type compilation implemented (not required to fix the bug but I was working on it)