Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nico/auth #32

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Fix/nico/auth #32

merged 8 commits into from
Oct 20, 2023

Conversation

NicoSerranoP
Copy link
Contributor

@NicoSerranoP NicoSerranoP commented Oct 19, 2023

Close #31

  1. Fix .env not read by npm problem
  2. typechain contract type compilation implemented (not required to fix the bug but I was working on it)
  3. Use the new contract ABI (latest version)
  4. Disable metaTx auth until WalletConnect/web3auth is implemented in frontend. We will trust the frontend and the users that they are sending urls from their wallet and not trying putting non-authorized addresses in the request to create URLs, Tags or Likes
  5. Fix url creation bug

src/server.ts Outdated
@@ -1,5 +1,5 @@
import * as dotenv from "dotenv";
dotenv.config({ path: __dirname+'/.env' });
dotenv.config();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Nico , the env is failing if we don't specify the path. Had this issue on render too and facing it locally too.

dotenv.config({ path: __dirname+'/.env' });

using dotenv like above make sure it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird :S are you using Linux? In my Windows setup it fails when we specify the path :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a new change reverting this, could you try to run this in your local? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I am running Linux . I can put it in try catch block i guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicoSerranoP NicoSerranoP merged commit 1d9d0e4 into main Oct 20, 2023
@NicoSerranoP NicoSerranoP deleted the fix/nico/auth branch October 23, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: submitting tags and url
2 participants