Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall functionality #97

Merged
merged 14 commits into from
Jul 1, 2022
Merged

Uninstall functionality #97

merged 14 commits into from
Jul 1, 2022

Conversation

adntaha
Copy link
Contributor

@adntaha adntaha commented Jul 1, 2022

No description provided.

@TrainDoctor TrainDoctor marked this pull request as ready for review July 1, 2022 23:40
@TrainDoctor TrainDoctor self-requested a review July 1, 2022 23:40
TrainDoctor
TrainDoctor approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked with @botatooo in pair programming on this feature. Works well except for a few minor cosmetic things and a unimportant aiohttp error. Good to merge.

@TrainDoctor TrainDoctor added the enhancement New feature or request label Jul 1, 2022
@TrainDoctor TrainDoctor added this to the React Release Candidate milestone Jul 1, 2022
@TrainDoctor TrainDoctor merged commit 4daf028 into SteamDeckHomebrew:react-frontend-plugins Jul 1, 2022
@adntaha adntaha deleted the botato/uninstall branch July 2, 2022 23:37
@TrainDoctor TrainDoctor mentioned this pull request Jul 3, 2022
Closed
KP2048 pushed a commit to EmuDeck/decky-loader that referenced this pull request May 4, 2023
@adntaha
Uninstall functionality (SteamDeckHomebrew#97)
ca21711 
* feat: POC uninstallation feature

* Fixes, placeholder

* bugfix: wrong function call

* add oncancel and change function called

* clean up plugin uninstall code

* bugfix, uninstall in store

* Limit scope of feature branch

* feat: PluginLoader.unloadPlugin

* problematic logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrainDoctor TrainDoctor TrainDoctor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
React Update Project
Status: ✅ Done
Milestone
React Release Candidate
Development

Successfully merging this pull request may close these issues.
2 participants
@adntaha @TrainDoctor