-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deck Settings #747
Add Deck Settings #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the license file with information or if you decide to use another license place the text for that license above the original in license file. Please delete the py_modules folder if you are not making use of it. The same for main.py if you're not utilizing the python backend as well.
Please update the description in package.json.
Please remove the flags from plugin.json and add plugin tags that match your plugin. Since you're plugin is not the template or using root, you can remove both of those tags. I don't see a reference to gamesearch component but the file is empty, is this for future use?
Please make these changes and your plugin can go to testing, thanks.
56712e0
to
bba4520
Compare
The GameSearch component completely sliped in there. Was replaced when I did the SearchResultsView.
|
bba4520
to
2a86a4a
Compare
@Josh5 please rebase on main to get rid of the playcount merge |
2a86a4a
to
9fc66b1
Compare
@TrainDoctor I have rebased to main. Thanks. |
This is a good idea. I've tested and it appears to work fine on Stable/Beta channels. It would be nice to somehow submit reports for games via the plugin, though or to somehow improve the plugin in such a way that it is capable of adding value to your database of reports. Otherwise, at the moment, it's a plugin that's only capable of showing 1 or 2 reports for a handful of games. If you added an option on the Game Page to allow users to submit "community" reports, I feel that even I would submit reports for some of the games I play. |
Plugin Testing ReportInstalled Plugins
Specifications
IssuesHas the following major blocking issue(s): NONE Summaryeverything seems to work well, though most games I tried said 0 reports. I suppose it's more of an issue with the site itself. Great plugin! |
Some good points raised. At the moment, the site and database are only a few weeks old. I imagine as it gets used more, the number of community supplied reports will grow. I will look into developing a method of easily submitting reports from the plugin in the future. At the moment, I'd recommend using a companion mobile view via the site or even the official github app for submitting reports. |
@Josh5 Your PR has been updated to use the latest version of the PR template. Please see the Community section of the Task Checklist regarding testing two other PRs to get the quickest response from our team. There are additional comments in the Markdown when you edit the PR text which you may find helpful. Thanks! |
Ignore my previous comment, looks like you have the testers you needed and Train already gave the initial code approval. I looked everything over and it seems good, so I'll go ahead and merge. Thanks for your contribution! |
Deck Settings
This plugin integrates with the Deck Settings API (https://deckverified.games) to fetch game compatibility and configuration reports. These reports are sourced from the community-driven repository at https://github.com/DeckSettings/game-reports-steamos. The plugin allows users to easily view game-specific performance tweaks, compatibility information, and configuration suggestions directly on their Steam Deck, streamlining the process of optimizing game settings for handheld devices.
Features:
This is the first submission of the plugin to the Decky plugin repository.
Task Checklist
Developer
Plugin
Backend
Community
Testing