SEP-10: Add muxed account and memo support #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 99.03% 99.04%
=======================================
Files 137 137
Lines 9537 9629 +92
=======================================
+ Hits 9445 9537 +92
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
overcat
approved these changes
Sep 16, 2021
overcat
pushed a commit
that referenced
this pull request
Sep 16, 2021
Allows muxed accounts to be passed for client_account_id and adds a memo parameter to ChallengeTransaction and build_challenge_transaction(). These changes implement the specification's update for pooled/shared/omnibus account support: #1036. These changes should be backported to all major versions that have the ChallengeTransaction class.
overcat
pushed a commit
that referenced
this pull request
Sep 16, 2021
Allows muxed accounts to be passed for client_account_id and adds a memo parameter to ChallengeTransaction and build_challenge_transaction(). These changes implement the specification's update for pooled/shared/omnibus account support: #1036. These changes should be backported to all major versions that have the ChallengeTransaction class.
|
Hi @JakeUrban, thanks for your contribution, I have included it in v4.2.0. |
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows muxed accounts to be passed for
client_account_idand adds amemoparameter toChallengeTransactionandbuild_challenge_transaction(). These changes implement the specification's update for pooled/shared/omnibus account support: #1036.These changes should be backported to all major versions that have the
ChallengeTransactionclass.