Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move build instructions from wiki to source root #960

Closed
wants to merge 6 commits into from

Conversation

…ium#958

wiki pages: version d0b60c4094b424de91e91846ea9a0818d183df18
- linux build dependencies
- compiling on linux
- compiling macos
- compiling windows
- RPi
- code testing
@gzotti
Copy link
Member

gzotti commented Feb 2, 2020

There are some hyperlinks esp. in the RaspberryPi part. These should no longer point to external .md files. Either change to in-doc hyperlinks, or (if that is not available) into phrases like "see ... above".

@axd1967 axd1967 requested a review from gzotti February 8, 2020 20:24
You may want to install a swap file, otherwise you may run out of virtual memory when compiling
[https://www.cyberciti.biz/faq/linux-add-a-swap-file-howto/](https://www.cyberciti.biz/faq/linux-add-a-swap-file-howto/)

Then, make sure to install the [build requirements](#lbuild-dependencies) and follow the [building instructions for Linux](#linux).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I randomly clicked on a few hyperlinks in an MD editor. This failed, program crashed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. what editor was that, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's possibly the GMD syntax that gives this issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Markdown Editor" by Poppen's Lab, my first usable contact with MD. I accept recommendations for better tools as long as they are free.

@axd1967
Copy link
Contributor Author

axd1967 commented Feb 10, 2020

To be honest, I don't use a Mardown editor (and a dev will just browse the text or browse the GitHub page). Often there are good plugins for IDE's: for example in PyCharm the links works fine.

image

I couldn't find that editor yet.

(I haven't set up a good Stellarium dev environment yet to evaluate markdown plugins.)

@axd1967
Copy link
Contributor Author

axd1967 commented Mar 1, 2020

@gzotti
Can we proceed with the merge? We cannot test every possible code editor. The essence is that the text can be read in a simple text editor. Essence is that a developer should have a single place where all information is present; avoid two places that have to be maintained in parallel, which is confusing.

@gzotti
Copy link
Member

gzotti commented Mar 1, 2020

In the last weeks other things were more important than where to place build instructions. Of course there should only be one place. If we combine all docs to one, who shall go through the text and reduce e.g. git duplicates or harmonize instructions? E.g. Raspberry notes may be a part of Linux.
@alex-w any comments?

@alex-w
Copy link
Member

alex-w commented Mar 2, 2020

Just copying few documents into one big document is not very good solution.

For example you are wrote in the first paragraph:

Each time Stellarium is released, the source code is released in Github's packaging system. Building source code that is released in this way should give you a working copy of Stellarium which is functionally identical to the binaries for that release.

and in paragraph 15 (Qt versions) user may see:

Stellarium 0.13.0 required Qt version 5.1.0 or above for building....

Seriously? You proposed moving and restructure the building instruction for offline usage and those instructions should be actual. Sorry, but this version of instructions is not actual.

If you began using Qt 5.5 for Linux as example, then you need use same version for macOS and Windows too. At the moment minimal version Qt for building master version of Stellarium is 5.6.0, but we recommended using Qt 5.9 or, better, Qt 5.12 (both - LTS) for building planetarium.

Other problem: the BUILDING.md file missing important part for building the binary package from source code - configuration options - http://stellarium.sourceforge.net/wiki/index.php/Configuring_Build_Options

Yes, the list of options is not actual now and it should be revised. Of course part of instructions, who related to Raspberry Pi need move to Linux block with remarks.

Many parts of text are redundant by historical reasons and it should be revised too - so, final document need editing and proofreading!

@axd1967 axd1967 mentioned this pull request Mar 4, 2020
12 tasks
@axd1967
Copy link
Contributor Author

axd1967 commented Mar 23, 2020

PLEASE! I cannot

  • move the instructions
  • AND update them!

I have no vision on everything that changed, and cannot know it completely.

Can we PLEASE split this into TWO steps:

  1. move the instructions
  2. update the instructions

by blocking this PR because the instructions are outdated is a bad idea, this will never close this issue.

I never proposed to UPDATE the instructions.

@alex-w
Copy link
Member

alex-w commented Mar 23, 2020

@axd1967, sorry, but who are wrote advantages list in the issue #958? O_O

@axd1967
Copy link
Contributor Author

axd1967 commented Mar 23, 2020

All I write is

Move the wiki documentation (16 files of about 100kb in total) into a subdirectory in the source tree.

@gzotti
Copy link
Member

gzotti commented Aug 17, 2020

I think this is also superseded and can be closed.

@alex-w alex-w closed this Aug 25, 2020
@axd1967 axd1967 deleted the contrib/merge_docs branch November 14, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

merge repos: move wiki documentation into source folders
3 participants