Static analysis cruft

SteveGilham · Jul 16, 2024 · 3c60ccc · 3c60ccc
1 parent 1e9a86d
commit 3c60ccc
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 14 deletions.
diff --git a/AltCover.Base/AltCover.Base.csproj b/AltCover.Base/AltCover.Base.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <RootNamespace>AltCover</RootNamespace>
     <AssemblyName>AltCover.Base</AssemblyName>
-    <GlobalDefineConstants>RUNNER</GlobalDefineConstants>
+    <GlobalDefineConstants>RUNNER;LITEVERSION</GlobalDefineConstants>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">
@@ -15,6 +15,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <Compile Include="..\_Generated\AssemblyVersion.cs" Link="AssemblyVersion.cs" />
     <Compile Include="..\_Generated\VisibleToTest.cs" Link="VisibleToTest.cs" />
     <Compile Include="..\AltCover.Recorder\Base.cs" Link="Base.cs" />
     <None Include="..\AltCover.Recorder\Base.fs" Link="Base.fs" />

diff --git a/AltCover.Recorder/Base.cs b/AltCover.Recorder/Base.cs
@@ -48,12 +48,24 @@ internal enum ReportFormat
     Zipped = 128,
   };
 
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "AvoidUncalledPrivateCodeRule",
+                   Justification = "Internals Visible To")]
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "AvoidUninstantiatedInternalClassesRule",
+                   Justification = "Internals Visible To")]
   internal enum Sampling
   {
     All = 0,
     Single = 1,
   };
 
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "AvoidUncalledPrivateCodeRule",
+                   Justification = "Internals Visible To")]
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "AvoidUninstantiatedInternalClassesRule",
+                   Justification = "Internals Visible To")]
   internal enum Tag
   {
     Null = 0,
@@ -64,11 +76,23 @@ internal enum Tag
   }
 
   [ExcludeFromCodeCoverage]
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
+  [SuppressMessage("Gendarme.Rules.Design",
+                   "OperatorEqualsShouldBeOverloadedRule",
+                   Justification = "No use case")]
   internal struct Pair
   {
     public long Time;
     public int Call;
 
+    [SuppressMessage("Gendarme.Rules.Performance",
+                     "AvoidUncalledPrivateCodeRule",
+                     Justification = "Internals Visible To")]
+    [SuppressMessage("Gendarme.Rules.Performance",
+                     "OverrideValueTypeDefaultsRule",
+                     Justification = "You what, mate?")]
     public static Pair Create(long time, int call)
     {
       return new Pair { Time = time, Call = call };
@@ -97,10 +121,13 @@ public override int GetHashCode()
     }
   }
 
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "abstract type, No use case")]
   internal abstract class Track
   {
-    internal static readonly string Entry = "\u2611"; // BALLOT BOX WITH CHECK
-    internal static readonly string Exit = "\u2612"; // BALLOT BOX WITH X
+    internal const string Entry = "\u2611"; // BALLOT BOX WITH CHECK
+    internal const string Exit = "\u2612"; // BALLOT BOX WITH X
 
     public override bool Equals(object obj)
     {
@@ -113,6 +140,9 @@ public override int GetHashCode()
     }
   }
 
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
   internal class Null : Track
   {
     public override string ToString()
@@ -131,6 +161,9 @@ public override int GetHashCode()
     }
   }
 
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
   internal class Time : Track
   {
     public readonly long Value;
@@ -142,9 +175,9 @@ public Time(long time)
 
     public override bool Equals(object obj)
     {
-      if (obj is Time)
+      if (obj is Time t)
       {
-        return Value == ((Time)obj).Value;
+        return Value == t.Value;
       }
 
       return false;
@@ -161,7 +194,10 @@ public override string ToString()
     }
   }
 
-  internal class Call : Track
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
+  internal sealed class Call : Track
   {
     public readonly int Value;
 
@@ -172,9 +208,9 @@ public Call(int call)
 
     public override bool Equals(object obj)
     {
-      if (obj is Call)
+      if (obj is Call c)
       {
-        return Value == ((Call)obj).Value;
+        return Value == c.Value;
       }
 
       return false;
@@ -191,7 +227,10 @@ public override string ToString()
     }
   }
 
-  internal class Both : Track
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
+  internal sealed class Both : Track
   {
     public readonly Pair Value;
 
@@ -222,7 +261,7 @@ public override string ToString()
     }
   }
 
-  internal class Table : Track
+  internal sealed class Table : Track
   {
     public readonly Dictionary<string, Dictionary<int, PointVisit>> Value;
 
@@ -232,7 +271,10 @@ public Table(Dictionary<string, Dictionary<int, PointVisit>> table)
     }
   }
 
-  internal class PointVisit
+  [SuppressMessage("Gendarme.Rules.Performance",
+                   "ImplementEqualsTypeRule",
+                   Justification = "No use case")]
+  internal sealed class PointVisit
   {
     public long Count;
     public readonly List<Track> Tracks;
@@ -300,6 +342,9 @@ internal long Total
 
   internal static class Counter
   {
+    [SuppressMessage("Gendarme.Rules.Design.Generic",
+                     "AvoidDeclaringCustomDelegatesRule",
+                     Justification = "Net Framework 2.0")]
     public delegate void PointProcessor(XmlElement doc, IEnumerable<Track> tracking);
 
     // <summary>
@@ -327,7 +372,8 @@ internal static class Counter
 
     internal static class I
 #else
-    static private class I
+
+    private static class I
 #endif
     {
       internal struct coverXml
@@ -482,6 +528,12 @@ private static XmlDocument readXDocument(Stream stream)
       private static void writeXDocument(XmlDocument coverageDocument, Stream stream)
       { coverageDocument.Save(stream); }
 
+      [SuppressMessage("Gendarme.Rules.Smells",
+                       "AvoidLongMethodsRule",
+                       Justification = "Well tested code")]
+      [SuppressMessage("Gendarme.Rules.Smells",
+                       "AvoidLongParameterListsRule",
+                       Justification = "Stable code")]
       public static DateTime updateReport(
       Action<XmlDocument> postProcess,
       PointProcessor pointProcess,
@@ -605,6 +657,9 @@ out var vc
         return flushStart;
       }
 
+      [SuppressMessage("Gendarme.Rules.Smells",
+                       "AvoidLongParameterListsRule",
+                       Justification = "Stable code")]
       public static TimeSpan doFlush(
         Action<XmlDocument> postProcess,
         PointProcessor pointProcess,
@@ -644,6 +699,9 @@ Track context
 
 #if RUNNER
 
+    [SuppressMessage("Gendarme.Rules.Performance",
+                     "AvoidUncalledPrivateCodeRule",
+                     Justification = "Internals Visible To")]
     internal static long addVisit(
       Dictionary<string, Dictionary<int, PointVisit>> counts,
       string moduleId,
@@ -660,9 +718,12 @@ Track context
       return 1;
     }
 
+    [SuppressMessage("Gendarme.Rules.Performance",
+                     "AvoidUncalledPrivateCodeRule",
+                     Justification = "Internals Visible To")]
     [SuppressMessage("Gendarme.Rules.Smells",
-                      "AvoidLongParameterListsRule",
-                      Justification = "Most of this gets curried away")]
+                       "AvoidLongParameterListsRule",
+                       Justification = "Stable code")]
     public static TimeSpan doFlushStream(
       Action<XmlDocument> postProcess,
       PointProcessor pointProcess,