Skip to content

Commit

Permalink
Fix lurking issue exposed by SDK update
Browse files Browse the repository at this point in the history
  • Loading branch information
SteveGilham committed Aug 10, 2022
1 parent 9762805 commit ac99c45
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 14 deletions.
11 changes: 3 additions & 8 deletions Build/targets.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -6800,14 +6800,9 @@ _Target "Issue114" (fun _ ->
csproj.Descendants(XName.Get("PackageReference"))
|> Seq.head

let inject =
XElement(
XName.Get "PackageReference",
XAttribute(XName.Get "Include", "altcover.api"),
XAttribute(XName.Get "Version", Version.Value)
)

pack.AddBeforeSelf inject
// Bump API version
Assert.That(pack.Attribute(XName.Get "Include").Value, Is.EqualTo "AltCover.Api")
pack.Attribute(XName.Get "Version").Value <- Version.Value
csproj.Save "./_Issue114/Sample26.fsproj"
Shell.copy "./_Issue114" (!! "./Samples/Sample26/*.fs")

Expand Down
12 changes: 6 additions & 6 deletions Samples/Sample26/Sample26.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="AltCover.Api" Version="7.5.809" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
<PackageReference Include="NUnit" Version="3.13.0" />
<PackageReference Include="NUnit3TestAdapter" Version="3.17.0">
<PackageReference Include="AltCover.Api" Version="8.3.838" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.0" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
<PackageReference Include="Unquote" Version="5.0.0" />
<PackageReference Include="Unquote" Version="6.1.0" />
</ItemGroup>

<ItemGroup>
<PackageReference Update="FSharp.Core" Version="5.0.1">
<PackageReference Update="FSharp.Core" Version="6.0.5">
<ExcludeAssets>contentfiles</ExcludeAssets>
</PackageReference>
</ItemGroup>
Expand Down

0 comments on commit ac99c45

Please sign in to comment.