Skip to content

Commit

Permalink
Make public some APIs that had been auto-internalized.
Browse files Browse the repository at this point in the history
Two more glitches to fix
  • Loading branch information
SteveGilham committed Jul 20, 2024
1 parent 20fd71c commit b2cab65
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 49 deletions.
10 changes: 5 additions & 5 deletions AltCover.Recorder/Recorder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ public static class Instance
/// Gets the location of coverage xml file
/// This property's IL code is modified to store the actual file location
/// </summary>
internal static string ReportFile
public static string ReportFile
{
[MethodImpl(MethodImplOptions.NoInlining)]
get { return "Coverage.Default.xml"; }
}

internal static string ReportFilePath
public static string ReportFilePath
{
get
{
Expand All @@ -53,7 +53,7 @@ internal static string CanonicalPath(string path)
/// Gets whether to defer output until process exit
/// This property's IL code is modified to store the actual value
/// </summary>
internal static bool Defer
public static bool Defer
{
[MethodImpl(MethodImplOptions.NoInlining)]
get { return false; }
Expand Down Expand Up @@ -101,7 +101,7 @@ internal static Sampling Sample
/// Gets the unique token for this Instance
/// This property's IL code is modified to store a GUID-based token
/// </summary>
internal static string Token
public static string Token
{
[MethodImpl(MethodImplOptions.NoInlining)]
get { return "AltCover"; }
Expand Down Expand Up @@ -892,7 +892,7 @@ public static void Pop()
[SuppressMessage("Gendarme.Rules.Performance",
"AvoidUncalledPrivateCodeRule",
Justification = "Internals Visible To")]
internal static void FlushFinish()
public static void FlushFinish()
{
I.FlushAll(Close.ProcessExit);
}
Expand Down
64 changes: 20 additions & 44 deletions rework failure list.txt
Original file line number Diff line number Diff line change
@@ -1,52 +1,28 @@
Issue72 00:00:08.1871717 (

(found, "first") = (["1"; "4"; "3"; "1"; "2"; "1"; "1"; "1"; "5"; "5"], "first")
(["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"], "first") = (["1"; "4"; "3"; "1"; "2"; "1"; "1"; "1"; "5"; "5"], "first")
false
)

DotnetTestIntegration 00:00:17.4145571 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0";
"0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_DotnetTest\coverage.net8.0.xml
Assert.That(, )
String lengths are both 39. Strings differ at index 2.
Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1"
But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0"
-------------^
)

Cake2Test 00:00:43.1579842 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0";
"0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_Cake\_DotnetTest\coverage.build.cake.--version 2.0.0.net8.0.xml
Assert.That(, )
String lengths are both 39. Strings differ at index 2.
Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1"
But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0"
-------------^
)


ApiUse 00:00:15.8093949 ( Bad visit list ["0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0"; "0";
"0"; "0"; "0"; "0"] in C:\Users\email\Documents\Github\altcover\_ApiUse\_DotnetTest\coverage.net8.0.xml
Assert.That(, )
String lengths are both 39. Strings differ at index 2.
Expected: "0 1 1 1 1 1 1 1 1 0 0 0 0 0 0 0 2 1 1 1"
But was: "0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0"
-------------^
)

WindowsPowerShell
WindowsPowerShell, Pester
missing methods
Void AltCover.LCov.convertReport
XDocument AltCover.Cobertura.convertReport
Void AltCover.CoverageParameters.set_theReportFormat
Void AltCover.PostProcess.action
String AltCover.Json.xmlToJson

Pester - ditto

UnitTestWithAltCoverCoreRunner
Failed AltCoverMonitorTests.MonitorTests.ShouldRecordPointTotals [417 ms]
Error Message:
Object reference not set to an instance of an object.
Stack Trace:
at AltCover.Local.Monitor.TryGetPointTotals(PointCount& totals) in C:\Users\email\Documents\Github\altcover\AltCover.Monitor\Monitor.cs:line 161
var xml = i.GetProperty("ReportFile").GetValue(null, Type.EmptyTypes).ToString();
AltCover.Recorder -> C:\Users\email\Documents\Github\altcover\_Binaries\UnitTestWithCoreRunner_AltCover
.Recorder\Debug+AnyCPU\net46\AltCover.Recorder.dll
C:\Program Files\dotnet\sdk\8.0.303\FSharp\Microsoft.FSharp.Targets(332,9): error MSB6004: The specified
task executable location "C:\Program Files\dotnet\sdk\8.0.303\FSharp\fsc.exe" is invalid. [C:\Users\email
\Documents\Github\altcover\__AltCover.Recorder.Tests\AltCover.Recorder.Tests.fsproj::TargetFramework=net4
72]
C:\Program Files\dotnet\sdk\8.0.303\FSharp\Microsoft.FSharp.Targets(332,9): error MSB6004: The specified
task executable location "C:\Program Files\dotnet\sdk\8.0.303\FSharp\fsc.exe" is invalid. [C:\Users\email
\Documents\Github\altcover\__AltCover.Recorder.Tests\AltCover.Recorder.Tests.fsproj::TargetFramework=net8
.0]
Finished (Failed) 'ReplayUnitTestWithAltCoverCoreRunner' in 00:01:55.4040158


Pester 00:00:00 (skipped)
Deployment 00:00:00 (skipped)
UnitTestWithAltCoverCoreRunner 00:00:00 (skipped)
UnitTest 00:00:00 (skipped)
BulkReport 00:00:00 (skipped)
All 00:00:00 (skipped)

0 comments on commit b2cab65

Please sign in to comment.