-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to towncrier for changelog #697
Migrating to towncrier for changelog #697
Conversation
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
+ Coverage 97.20% 97.21% +0.01%
==========================================
Files 42 42
Lines 7793 7797 +4
==========================================
+ Hits 7575 7580 +5
+ Misses 218 217 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @devanshshukla99, this is very useful!
An important thing to pay attention to: we should make sure that the format of the changelog is consistent with the old changelog, because the documentation build should have consistent titles. At the moment, the modifications of the development version have a different formatting, in particular a different title level.
Thanks for the review! |
This looks great! Thank you for implementing this! One thing I’m curious about: is the new changelog going to be displayed on our documentation? And if not, is there a way to make that happen? Doesn’t have to be in this PR. Just flagging it in case we should open another issue to do that. |
@dhuppenkothen I think it does, here: https://docs.stingray.science/history.html#changelog. The source file has an include instruction for CHANGELOG.rst. We should just make sure that the CHANGELOG generation is done before the docs build (Tagging @jdswinbank too here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devanshshukla99 we are almost there. The docs build is failing because the rst file of the towncrier snippet is not included in any toctree. Of course, it does not need to be included in any toctree, but there should be a way to avoid this conflict, for example excluding files with a given pattern in the name from sphinx.
Thanks @devanshshukla99 ! |
This Pull Request migrates the changelog to towncrier, fixes #554.
As described in the original issue, this PR adds relevant instructions on how to use towncrier as well as a gh-action workflow to check for the changelog entry.
Migrating to towncrier is pretty easy, instead of adding details to the
CHANGELOG.rst
, add a file named<pr number>.<type>.rst
todocs/changes/
directory.Right now, it supports following types (following suit of astropy and pytest):
breaking
: A change which is not backwards compatible and requires users to change code.feature
: New user facing features and any new behavior.bugfix
: Fixes a reported bug.doc
: Documentation improvement, like rewording an entire session or adding missing docs.deprecation
: Feature deprecation.removal
: Feature removal.trivial
: Fixes a small typo or internal change that might be noteworthy.With other relevant details available at
docs/changes/README.rst
The gh-action workflow
check-changelog.yml
will only check if there is a file named<pr number>.*.rst
and can be skipped by usingno-changelog-entry-needed
label on the PR.Changelog generated using
towncrier
: