Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate deprecated format_ keyword from read and write methods #729

Merged
merged 3 commits into from
May 18, 2023

Conversation

matteobachetti
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #729 (eb6a478) into main (9b269d9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   97.16%   97.15%   -0.01%     
==========================================
  Files          42       42              
  Lines        7872     7852      -20     
==========================================
- Hits         7649     7629      -20     
  Misses        223      223              
Impacted Files Coverage Δ
stingray/base.py 96.90% <100.00%> (-0.09%) ⬇️
stingray/events.py 100.00% <100.00%> (ø)
stingray/lightcurve.py 97.82% <100.00%> (-0.02%) ⬇️
stingray/simulator/simulator.py 100.00% <100.00%> (ø)
stingray/simulator/transfer.py 98.90% <100.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! We should make a note somewhere when we release a new version (in the version notes?) that this is a breaking change?

Mark modification as breaking
@matteobachetti
Copy link
Member Author

@dhuppenkothen this name change should be sufficient. Towncrier will take care of it.

@matteobachetti matteobachetti added this pull request to the merge queue May 18, 2023
Merged via the queue into main with commit 1c85c6b May 18, 2023
@matteobachetti matteobachetti deleted the eliminate_format_ branch May 18, 2023 16:07
@matteobachetti matteobachetti mentioned this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants